Put @types/node as an optional peerDependency #2169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinLemCode
requested review from
xavdid-stripe
and removed request for
a team
|
This will probably conflict with #2168 |
|
Sorry it's been so long since we looked at this! I believe optional peer + dev is the correct path forward, so thank you for suggesting that. It looks like the CI is failing on latest because the missing |
|
Hello @xavdid-stripe |
|
@xavdid-stripe Ready to merge :) |
nodoubtz
pushed a commit
to Dimvy-Clothing-brand/stripe-node
that referenced
this pull request
May 5, 2025
* Put @types/node as optional peerDependency * add undici types as devDependency * update tsconfig --------- Co-authored-by: David Brownman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This PR put @types/node as an optional peerDependency.
There was already previous attempt to move it to "devDependency" in order to avoid the size overhead of node types for Javascript project or even production builds.
#1274
However, this would cause issue because the Typescript compiler wouldn't provide correct error types.
In this PR, the
@types/nodelibrary as been put in devDependencies and in optional peerDependencies.This allow :