Remove some @ts-ignore #2167
Remove some @ts-ignore #2167
Conversation
QuentinLemCode
requested review from
helenye-stripe
and removed request for
a team
|
Looks like tests didn't run, i'm going to close and re-open the PR to see if it refreshes |
|
@QuentinLemCode looks like the build step is failing with a new type error. Can you address? |
Yes I see, this is caused by the old version of Typescript you use (4.9.4, latest is 5.5). My IDE was using latest version and so it did not show me the error. I will fix this but I recommend to upgrade your Typescript version which handle type inference more precisely |
|
There is a test failing on Node 12 related to one the changes you made in utils. Can you please fix that? |
Hello @prathmesh-stripe I found the culprit : the URL interpolator function should work with number, string or boolean. I have added a type guard to ensure the variable as the proper type, otherwize return ''. This allowed me to spot a potential bug, when using URL interpolator with the number 0, it would make the condition falsy and return an empty string |
|
@QuentinLemCode apologies for the slow reply here- it looks like your code has drifted from master. Can you pull latest and resolve any conflicts? |
Sure, should be OK now |
|
@xavdid-stripe Could you relaunch the CI please ? |
|
@xavdid-stripe Ready to merge :) |
xavdid-stripe
requested review from
xavdid-stripe
and removed request for
prathmesh-stripe
* Remove some @ts-ignore * Cast variable to string * Fix URLInterpolator to process every number, string or boolean value add test * use an array for headers for fetch (compatibiity) * Reapply changes * format * throw if signature unavailable --------- Co-authored-by: David Brownman <[email protected]>
Hello
I have open this PR in order to remove some @ts-ignore comments to improve Typescript type safety.
Types have been adjusted to reflect the correct usage in the codebase.
Some utility function has been added to parse headers to a proper value when needed.
Feel free to ask question and add review comments, I will update as needed
Thanks !