Refactor CaReconcilerTest to improve readability

[katheris]

Type of change

Select the type of your PR

• Refactoring

Description

Refactor the CaReconcilerTest class to improve readability.
This existing class is hard to follow since there are so many assertThat calls and many variables with similar names like clientsCaCertData, clientsCaKeyData, clusterCaCertData, clusterCaKeyData.
This PR pulls out the common asserts that check the certificate files and key files are all present and not null.
It also removes some variables that are only used once, again to improve readability.

Finally it removes the checks that compare the Ca truststore file as a whole. These checks are only passing
because in the Ca class in some cases we reuse the data directly, rather than instantiating a new hashmap.
The tests don't need to check the whether it is the exact same file, and in testExpiredCertsGetRemovedAuto we
actually wouldn't expect the file to be the same.
Since there are already checks that the correct cert is present in the truststore, the asserts that compare the whole file can be removed.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

• Write tests
• Make sure all tests pass
• Update documentation
• Check RBAC rights for Kubernetes / OpenShift roles
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
• Reference relevant issue(s) and close them after merging
• Update CHANGELOG.md
• Supply screenshots for visual changes, such as Grafana dashboards

[see-quick]

Thanks 👍

[ppatierno]

LGTM