Skip to content

Commit 70c5420

Browse files
Address nit and move prometheus-jmx-exporter examples into it's own directory
Signed-off-by: OwenCorrigan76 <[email protected]>
1 parent b666550 commit 70c5420

18 files changed

+6
-2
lines changed

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaCluster.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1869,7 +1869,7 @@ private String generatePerBrokerConfiguration(NodeRef node, KafkaPool pool, Map<
18691869
public List<ConfigMap> generatePerBrokerConfigurationConfigMaps(MetricsAndLogging metricsAndLogging, Map<Integer, Map<String, String>> advertisedHostnames, Map<Integer, Map<String, String>> advertisedPorts) {
18701870
String parsedMetrics = null;
18711871
if (metrics instanceof JmxPrometheusExporterModel exporter) {
1872-
parsedMetrics = (exporter).metricsJson(reconciliation, metricsAndLogging.metricsCm());
1872+
parsedMetrics = exporter.metricsJson(reconciliation, metricsAndLogging.metricsCm());
18731873
}
18741874
String parsedLogging = logging().loggingConfiguration(reconciliation, metricsAndLogging.loggingCm());
18751875
List<ConfigMap> configMaps = new ArrayList<>();

packaging/examples/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ include ../../Makefile.os
44

55
RELEASE_VERSION ?= latest
66
RELEASE_PATH ?= ../../strimzi-$(RELEASE_VERSION)/$(PROJECT_NAME)
7-
EXAMPLE_DASHBOARDS ?= metrics/grafana-dashboards/
7+
EXAMPLE_DASHBOARDS ?= metrics/prometheus-jmx-exporter/grafana-dashboards/
88
HELM_CHART_DASHBOARD_PATH ?= ../helm-charts/helm3/strimzi-kafka-operator/files/grafana-dashboards/
99

1010
ifneq ($(RELEASE_VERSION),latest)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Metrics configuration examples
2+
3+
The examples in this directory demonstrate how you can use configure metrics with Prometheus JMX Exporter Java agent.
4+
There are also some Grafana dashboards that you can use with them.

0 commit comments

Comments
 (0)