Skip to content

Commit b666550

Browse files
Remove jayway-json-path dependency from kafka-thirdparty-libs and add listener.enabed=true
Signed-off-by: OwenCorrigan76 <[email protected]>
1 parent 7e16090 commit b666550

File tree

4 files changed

+2
-2
lines changed

4 files changed

+2
-2
lines changed

cluster-operator/src/main/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilder.java

+1
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ public KafkaBrokerConfigurationBuilder withCruiseControl(String clusterName, Cru
145145
public KafkaBrokerConfigurationBuilder withStrimziMetricsReporter(StrimziMetricsReporterModel model) {
146146
if (model != null) {
147147
printSectionHeader("Strimzi Metrics Reporter configuration");
148+
writer.println("prometheus.metrics.reporter.listener.enable=true");
148149
writer.println("prometheus.metrics.reporter.listener=http://:" + StrimziMetricsReporterModel.METRICS_PORT);
149150
model.getAllowList().ifPresent(allowList -> writer.println("prometheus.metrics.reporter.allowlist=" + allowList));
150151
writer.println();

cluster-operator/src/test/java/io/strimzi/operator/cluster/model/KafkaBrokerConfigurationBuilderTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ public void testStrimziMetricsReporter() {
165165
.build();
166166

167167
assertThat(configuration, isEquivalent("node.id=2",
168+
"prometheus.metrics.reporter.listener.enable=true",
168169
"prometheus.metrics.reporter.listener=http://:" + StrimziMetricsReporterModel.METRICS_PORT,
169170
"prometheus.metrics.reporter.allowlist=kafka_log.*,kafka_network.*"));
170171
}

docker-images/artifacts/kafka-thirdparty-libs/3.9.x/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
<strimzi-oauth.version>0.15.0</strimzi-oauth.version>
2020
<strimzi-metrics-reporter.version>0.2.0</strimzi-metrics-reporter.version>
2121
<prometheus.version>1.3.6</prometheus.version>
22-
<jayway-json-path.version>2.9.0</jayway-json-path.version>
2322
<cruise-control.version>2.5.142</cruise-control.version>
2423
<opa-authorizer.version>1.5.1</opa-authorizer.version>
2524
<kafka-quotas-plugin.version>0.3.1</kafka-quotas-plugin.version>

docker-images/artifacts/kafka-thirdparty-libs/4.0.x/pom.xml

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
<strimzi-oauth.version>0.15.0</strimzi-oauth.version>
2020
<strimzi-metrics-reporter.version>0.2.0</strimzi-metrics-reporter.version>
2121
<prometheus.version>1.3.6</prometheus.version>
22-
<jayway-json-path.version>2.9.0</jayway-json-path.version>
2322
<cruise-control.version>2.5.142</cruise-control.version>
2423
<opa-authorizer.version>1.5.1</opa-authorizer.version>
2524
<kafka-quotas-plugin.version>0.3.1</kafka-quotas-plugin.version>

0 commit comments

Comments
 (0)