Skip to content

Improve some wording of contributing.md #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

peternewman
Copy link
Collaborator

Off the back of 9826833

@peternewman peternewman requested a review from matkoniecz June 23, 2021 10:22
* Edit [the FAQ](https://wiki.openstreetmap.org/wiki/StreetComplete/FAQ) and add reoccurring questions.
* Edit [the main StreetComplete page](https://wiki.openstreetmap.org/wiki/StreetComplete).
* Edit [the JSON of all tags used by StreetComplete](https://github.com/goldfndr/StreetCompleteJSON) that is displayed on [taginfo](https://taginfo.openstreetmap.org/projects/streetcomplete).
* Edit [the JSON of all tags used by StreetComplete](https://github.com/goldfndr/StreetCompleteJSON) that is displayed on [taginfo](https://taginfo.openstreetmap.org/projects/streetcomplete); there is a [draft Pull Request](https://github.com/streetcomplete/StreetComplete/pull/2754) to automate this).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure is it useful to link draft PRs - it will become stale soon either way (either it will be closed unfinished or become implemented)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I pondered about it, but I'd feel bad if someone spent a load of time manually crafting JSON to update the existing stuff by hand in the time between this getting merged and the automatic generation getting merged, when this PR has already done that processing.

I'd hope worst case even if it wasn't deemed practical to generate the full replacement JSON, it would remain as a service a bit like the CSV thing, to simplify manual updates, but that's probably a discussion for #2754 ...

@westnordost westnordost merged commit 1fa40b6 into streetcomplete:master Jun 24, 2021
@westnordost
Copy link
Member

👍

@matkoniecz
Copy link
Member

@peternewman Big thanks for such language review, it is one of things that I know that I am doing not really well and I appreciate help.

@peternewman peternewman deleted the patch-6 branch September 9, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants