Skip to content

Update to secrecy 0.10. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Update to secrecy 0.10. #13

merged 3 commits into from
Nov 3, 2024

Conversation

tmpfs
Copy link
Contributor

@tmpfs tmpfs commented Oct 26, 2024

Hi,

I am trying to update rage to [email protected] but that requires updating pinentry first.

Can you review this please?

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 7.42%. Comparing base (7410d73) to head (6eacb17).

Files with missing lines Patch % Lines
src/lib.rs 0.00% 4 Missing ⚠️
src/assuan.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #13      +/-   ##
========================================
- Coverage   7.89%   7.42%   -0.48%     
========================================
  Files          3       3              
  Lines        228     229       +1     
========================================
- Hits          18      17       -1     
- Misses       210     212       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6eacb17


[dependencies]
log = "0.4"
nom = { version = "7", default-features = false }
percent-encoding = "2.1"
secrecy = "0.8"
secrecy = "0.10"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This required an MSRV bump to 1.60, which I have done.

@str4d str4d merged commit 82475e0 into str4d:main Nov 3, 2024
10 checks passed
@str4d str4d mentioned this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants