feat(auth): Allow to hide username / password login form when OAuth is enabled #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled * Hide “Sign in” password form * Disable routes related to password authentication * Change styling of OAuth provider buttons * Open OAuth page in same tab * Fix consistent usage of informal language in de-DE locale Fixes #489 Signed-off-by: Marvin A. Ruder <[email protected]>
marvinruder
changed the title
|
I changed the OAuth button layout a bit to have them take a bit more room when those buttons are the only thing shown on the card. It looks nice even with the username / password form present, so I kept it there as well. New and larger buttons on the “Sign in” page: 
With OAuth providers only: 
I also noticed that clicking on an OAuth button opens its authentication page in a new tab, and after authentication Pingvin Share is opened in the same new tab while the first tab remains unused and still shows the “Sign in” page. That behavior seemed unintentional, and I changed the buttons’ behavior to open the OAuth provider page in the same tab. |
stonith404
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489
Signed-off-by: Marvin A. Ruder [email protected]