fix: Resolve panic when manifest has an int

[dhaiducek]

The unstructured package made the decision to not support int types, but that's exactly what our YAML marshaler uses. Changing to type assertions avoids the panic.

ref: https://issues.redhat.com/browse/ACM-18816

[dhaiducek]

/cherry-pick release-2.13

[openshift-cherrypick-robot]

@dhaiducek: once the present PR merges, I will cherry-pick it on top of release-2.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dhaiducek]

/cherry-pick release-2.12

[openshift-cherrypick-robot]

@dhaiducek: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dhaiducek]

/hold there might be a simpler option here...

[dhaiducek]

This is the key piece. Kubernetes decided int isn't a safe type, so we need to unmarshal with the Kubernetes YAML parser so it parses to int64 and then we can use the subsequent unstructured calls. The alternative is the route I started out on to manually do the indexing and type assertions.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[JustinKuli]

LGTM, thanks for figuring this one out!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dhaiducek]

/unhold

[openshift-cherrypick-robot]

@dhaiducek: #203 failed to apply on top of branch "release-2.13":

Applying: fix: Resolve panic when manifest has an `int`
Using index info to reconstruct a base tree...
M	cmd/template-resolver/client_test.go
M	cmd/template-resolver/utils/resolver_utils.go
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging cmd/template-resolver/utils/resolver_utils.go
Auto-merging cmd/template-resolver/client_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: Resolve panic when manifest has an `int`

In response to this:

/cherry-pick release-2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@dhaiducek: #203 failed to apply on top of branch "release-2.12":

Applying: fix: Resolve panic when manifest has an `int`
Using index info to reconstruct a base tree...
M	cmd/template-resolver/client_test.go
M	cmd/template-resolver/utils/resolver_utils.go
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging cmd/template-resolver/utils/resolver_utils.go
Auto-merging cmd/template-resolver/client_test.go
CONFLICT (content): Merge conflict in cmd/template-resolver/client_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: Resolve panic when manifest has an `int`

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.