-
Notifications
You must be signed in to change notification settings - Fork 15
Add skip-validation
flag; Remove default save path
#194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip-validation
flag; Remove default save path
#194
Conversation
Do we need a unit test like your example
|
Yes, we most definitely do 🙂 I think I wasn't 100% sure this PR was desirable. I'll add a test, though! |
Does this only skip "validation" around Policy/ConfigurationPolicy details? As in, if I gave it an invalid template that doesn't close a If so, I'm wondering if this option should be renamed to "non-policy" or something similar. |
That's correct. True, something like |
45b9ad6
to
7851b08
Compare
Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
7851b08
to
ac59808
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Feature:
--skip-validation
flag in order to do things like (you know, just off the top of my head 😂):Fix:
s
from save resources so that resources are not saved by default.