Skip to content

fixed some strict mode issues #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

marilynel
Copy link
Contributor

@marilynel marilynel commented Jul 13, 2025

#980

Addressed strict mode issues with boolean and null casing in values, and boolean, null, and number as keys.

Copy link

@stleary stleary changed the title fixed some strict mode issues 980 fixed some strict mode issues Jul 14, 2025
@stleary
Copy link
Owner

stleary commented Jul 14, 2025

What problem does this code solve?
Fixes problems where Strict mode was not enforcing case for non-string values, and allowing non-string keys.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added

Was any code refactored in this commit?
No. Sonarqube found some minor issues. Submitter can fix them if time permits, otherwise I will fix them later.

Review status
APPROVED

Starting 3-day comment window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants