Skip to content

tech-debt-25250701 #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

tech-debt-25250701 #994

merged 1 commit into from
Jul 8, 2025

Conversation

stleary
Copy link
Owner

@stleary stleary commented Jul 5, 2025

Description

  • Add Jacoco to build.gradle
  • Restore method check to original location in populationMap(), to ensure performance is not impacted.

Refactoring
None

Testing done

  • Confirmed Jacoco works as expected
  • Ran gradle tests, gradle strict tests, maven tests, and maven strict tests

Copy link

sonarqubecloud bot commented Jul 5, 2025

@stleary
Copy link
Owner Author

stleary commented Jul 5, 2025

What problem does this code solve?
Adds Jacocoo to gradle build, restores location of method check in JSONObject.populateMap()

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
The JSONObject change was a refactor.

Review status
APPROVED - by myself

Starting 3-day comment window

@stleary stleary merged commit a79e8a1 into master Jul 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant