Software PWM Work #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahoslove
reviewed
Aug 2, 2018
|
|
||
| //Internal PWM execution loop | ||
| func (swPwm *SoftwarePWM) pwmLoop(){ | ||
| go func(){ |
There was a problem hiding this comment.
No need to use anonymous function, you can use go swPwm.pwmLoop() in Start() method above.
| func (swPwm *SoftwarePWM) pwmLoop(){ | ||
| go func(){ | ||
| var sleepInterval time.Duration | ||
| for swPwm.status == RUNNING { |
There was a problem hiding this comment.
There is no need for ON/OFF state if you use something like this:
for {
if status != RUNING { breake }
pin.Write(High)
time.Sleep(...)
if status != RUNING { breake }
pin.Write(Low)
time.Sleep(...)
}
There was a problem hiding this comment.
Or better break using select and channel as I mentioned before.
select {
case <-stop:
break
default:
}
I would also use time.Ticker instead of time.Sleep, for better accuracy.
|
|
||
| //Stops the software PWM | ||
| func (swPwm *SoftwarePWM) Stop(){ | ||
| swPwm.status = STOPPED |
There was a problem hiding this comment.
I think go way to stop the loop might be to use "terminating" channel. Using status value like this is not thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is quite ready to be merged in quite yet. But I wanted to get your input earlier rather than later. I was needing some software based PWMs and saw the issue. So I hacked one together tonight real quick. It works pretty alright, the biggest thins is that I want to make it feel more consistent with your current lib. Not having to use construction methods and the like. But with the little bit thats there, what are your thoughts? Do you have any issues with running a goroutine for the pwm? Any blaring issues I missed?
Let me know