[202311][SSD] Bug fix: the logic to match the vendor specific attribute is not accurate #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic to match the vendor-specific attribute in SSD API is not accurate. The vendor-specific attribute should start with a new line (
\n
) otherwise it can hit a false match scenario.Motivation and Context
How Has This Been Tested?
Unit test and manual test
Additional Information (Optional)
Eg. if the raw value of an attribute happens to contain the ID, the next line can be matched but it is wrong.
For example the vendor-specific attribute ID is 248, but the output is like the following:
The raw value of attribute 235 contains
248
, the next line, which is of attribute 237, will be matched, which is wrong.