Skip to content

Adding crt-guest-advanced-HD shader #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 24, 2024

Conversation

Michael-Prince-Sharpe
Copy link
Contributor

No description provided.

@stenzek
Copy link
Owner

stenzek commented Apr 23, 2024

Please don't change the line endings for a bunch of unrelated files. Only add the new file.

If this shader is not public domain, it should also be added to the data/resources/thirdparty.html file, at the end with the other shader copyright notices.

@Michael-Prince-Sharpe
Copy link
Contributor Author

Michael-Prince-Sharpe commented Apr 23, 2024

Sorry about that, hopefully this restructure should fix that. The shader is public licenced like crt-royale. (public licence v2)

@stenzek
Copy link
Owner

stenzek commented Apr 24, 2024

License header in the file shows GPLv2+, therefore a copyright/attribution statement is absolutely required.

@Michael-Prince-Sharpe
Copy link
Contributor Author

Sorry about the typo, I mean v2 not 3 (or as you said v2+) my communication is terrible I went back and changed it, I've added relevant information under the files asked. Is this alright? Just let me know if it is.

@stenzek
Copy link
Owner

stenzek commented Apr 24, 2024

Line endings look like they've been changed accidentially.

@Michael-Prince-Sharpe
Copy link
Contributor Author

Michael-Prince-Sharpe commented Apr 24, 2024

Thanks, turns out it was a problem with my editors so used github itself to edit the thirdparty and source files so here's hoping this should fix the issue and github indicates that it doesn't conflct with the base branch.

@stenzek
Copy link
Owner

stenzek commented Apr 24, 2024

Yup, seems fine now.

@stenzek stenzek merged commit 9d3f328 into stenzek:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants