-
Notifications
You must be signed in to change notification settings - Fork 808
feat(hydrate): add serializeShadowroot
to hydrateDocument
#6259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hydrate): add serializeShadowroot
to hydrateDocument
#6259
Conversation
e00c071
to
eda4107
Compare
f022830
to
db595bc
Compare
serializeShadowroot
to hydrateDocument
serializeShadowroot
to hydrateDocumentserializeShadowroot
to hydrateDocument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Awesome, thanks!
@Armand-Lluka it seems like the e2e tests are failing:
|
d64cdca
to
09327e0
Compare
Looks like I was running the wrong test suite 🙈 I've updated the type in |
09327e0
to
a9a89eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last request: can we remove serializeShadowRoot
from SerializeDocumentOptions
since it extends HydrateDocumentOptions
where it is now being defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What is the current behavior?
GitHub Issue Number: #6240
What is the new behavior?
hydrateDocument
has been extended to provide theserializeShadowRoot
opt to be inline with what is provided withrenderToString
Documentation
Does this introduce a breaking change?
Testing
Test was added to
test.e2e.ts
to verify the new optionOther information