Rust: Serialize 64-bit integers as strings in xdr-json #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
leighmcculloch
commented
May 12, 2025
leighmcculloch
commented
May 12, 2025
leighmcculloch
commented
May 12, 2025
dmkozh
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add handling for 64-bit integers in XDR structures to ensure they are serialized as strings in JSON. Adds the handling in the cases of struct fields, union (enum) fields, and typedef (unamed struct) fields.
Why
JavaScript has limited precision for integers larger than 53 bits, requiring large integers to be represented as strings to prevent data loss. Today those integers are rendered as numbers which requires that folks use non-native JSON parsers in JavaScript runtimes.
Close #181