SEP-51: XDR-JSON Specification #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
Shaptic
reviewed
Apr 21, 2025
ecosystem/sep-XDRJSON.md
Outdated
Comment on lines
138
to
141
| _Note: JavaScript runtime implementations of JSON do not support numbers that | ||
| require more than 53-bits. JavaScript applications should use a JSON decoder | ||
| supporting 64-bit numbers in JSON numbrs. JSON decoders in other languages do | ||
| not typically have this constraint and support numbers up to 64-bits._ |
There was a problem hiding this comment.
Edit: Moving to discussion, my bad
There was a problem hiding this comment.
Yup, that's why we have this open issue to change it, and also change the presentation of the 128 and 256 bit integer types too:
This PR captures the existing XDR-JSON format which has this wart unfortunately.
Fwiw while that issue has been open for a while, I think we'll prioritise it this year.
leighmcculloch
changed the title
tomerweller
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.