-
Notifications
You must be signed in to change notification settings - Fork 997
Load generator: add a new mode to pre-generate load offline #4671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marta-lokhova
merged 4 commits into
stellar:master
from
marta-lokhova:offlineLoadGeneration
Mar 27, 2025
Merged
Load generator: add a new mode to pre-generate load offline #4671
marta-lokhova
merged 4 commits into
stellar:master
from
marta-lokhova:offlineLoadGeneration
Mar 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
040d6de
to
4b1a608
Compare
anupsdf
reviewed
Mar 24, 2025
c9bf22c
to
f02632e
Compare
f02632e
to
eea1358
Compare
SirTyson
reviewed
Mar 26, 2025
SirTyson
previously approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a very helpful change! A few comments from me, mostly minor stuff.
bboston7
approved these changes
Mar 26, 2025
eea1358
to
1cf2ffc
Compare
SirTyson
previously approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1cf2ffc
to
5a29501
Compare
SirTyson
approved these changes
Mar 27, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves stellar/stellar-core-internal#345
Resolves https://github.com/stellar/stellar-core-internal/issues/339
Offline load generation has a few nice properties:
In addition, the new loadgen skips certain expensive validity checks, and adds pre-generated transactions directly into the tx queue, this further reduces the overhead of a load generation step.