Skip to content

Fixed counter bug in in-memory bucket indexes #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

Fixed counter bug in in-memory bucket indexes #4668

merged 2 commits into from
Mar 14, 2025
+141 −24

Conversation

SirTyson
Copy link
Contributor

Description

Resolves #4667

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

bboston7
bboston7 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@bboston7 bboston7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marta-lokhova marta-lokhova enabled auto-merge March 13, 2025 23:47
@marta-lokhova marta-lokhova added this pull request to the merge queue Mar 14, 2025
Merged via the queue into stellar:master with commit e6c1f3b Mar 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboston7 bboston7 bboston7 approved these changes

@marta-lokhova marta-lokhova marta-lokhova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In-memory buckets don't count entries
3 participants
@SirTyson @bboston7 @marta-lokhova