Skip to content

Better behavior when BucketListDB account cache disabled #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Feb 27, 2025

Description

This improves behavior when the account cache is disabled in BucketListDB. Previously, BUCKETLIST_DB_MEMORY_FOR_CACHING == 0 was still valid, but we would still create a random eviction cache object that had no capacity. This change makes is such that we don't construct the cache at all in this case. I've also added an explicit test.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@SirTyson SirTyson added this pull request to the merge queue Feb 28, 2025
Merged via the queue into stellar:master with commit 2b2aef9 Feb 28, 2025
13 checks passed
@SirTyson SirTyson deleted the disable-account-cache branch February 28, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants