Fix tests in --disable-postgres build
#4626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves stellar#4625 and stellar#4614. This change fixes the tests in the `--disable-postgres` build by disabling parallel ledger close tests when postgres is disabled. This is necessary because parallel ledger close requires postgres. As part of this, I also removed the `TESTDB_BUCKET_DB_PERSISTENT_POSTGRES` test mode, as it's made redundant by the `TESTDB_POSTGRESQL` mode.
SirTyson
previously approved these changes
Jan 17, 2025
bboston7
force-pushed
the
fix-disable-postgres-tests
branch
from
541a6dc to
2680210
Compare
SirTyson
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4625 and #4614.
This change fixes the tests in the
--disable-postgresbuild by disabling parallel ledger close tests when postgres is disabled. This is necessary because parallel ledger close requires postgres.As part of this, I also removed the
TESTDB_BUCKET_DB_PERSISTENT_POSTGREStest mode, as it's made redundant by theTESTDB_POSTGRESQLmode.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)