fix:support-classic-accounts-trustlines #1746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dhanraj30 Could you fix the coding formatting please |
Comment on lines
-292
to
+296
| LedgerKey::Trustline(k) => current.account_ids.contains(&k.account_id), | ||
| LedgerKey::Trustline(k) => { | ||
| current.account_ids.contains(&k.account_id) || | ||
| current.account_ids.iter().any(|id| match &k.asset { | ||
| TrustLineAsset::CreditAlphanum4(a4) => a4.issuer == *id, | ||
| TrustLineAsset::CreditAlphanum12(a12) => a12.issuer == *id, |
There was a problem hiding this comment.
Pulling in every trustline for an asset unfortunately doesn't scale well with the current implementation of snapshots, which was why I left it out. If you pass in the address for a very popular asset, the file becomes huge and unusable.
For assets with much less trust lines though I can see this being very useful so maybe we should add it.
I think this use case will be better served by the following issue that hopefully we can implement in the near future:
Thoguhts @fnando ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1739
What
support for classic accounts and trustlines in snapshots.
Why
Support classic accounts and trustlines in snapshots. This change is being made to ensure that legacy account and trustline information is correctly included in the ledger snapshots. Classic accounts and trustlines were previously overlooked, which caused issues
Known limitations
N/A