Implement BLS12-381 point negation #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
commented
Apr 3, 2025
jayz22
commented
Apr 3, 2025
jayz22
force-pushed
the
bls-point-negation
branch
from
7eb5bff to
cfe74d4
Compare
There was a problem hiding this comment.
I reviewed the interface that developers will be exposed to and I think it looks good. I left just a couple minor comments for renaming functions to .to_ and implementing From instead of Into, and other traits to impl, and then one follow up issue for us to consider #1462.
@stellar/contract-committers Is someone from the core team able to review the internal BLS details?
dmkozh
reviewed
Apr 29, 2025
This reverts commit c83e413.
dmkozh
approved these changes
May 7, 2025
anupsdf
reviewed
May 7, 2025
anupsdf
reviewed
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Split out point negation part (0945897) from #1449, and address review comments on this part.
Why
Improves usability of the BLS12-381 features in a Groth16 verifier application (example contract)
Negis an common operation, needed for using the proof parameter as pairing input, and is cheap and simple enough to be implemented as an sdk function.Known limitations
[TODO or N/A]