Skip to content

Saved Smart Contract IDs #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2025
Merged

Saved Smart Contract IDs #1392

merged 6 commits into from
May 9, 2025

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented May 7, 2025 •
edited
Loading

image

image

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX May 7, 2025
@quietbits quietbits linked an issue May 7, 2025 that may be closed by this pull request
Saved Contracts #1348
Closed
3 tasks
@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1392.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1392.previews.kube001.services.stellar-ops.com/

@quietbits quietbits requested a review from jeesunikim May 7, 2025 18:24
@jeesunikim
Copy link
Contributor

jeesunikim commented May 8, 2025 •
edited
Loading

This doesn't have to be included in this PR, but I'd like the 'save' button to be clickable by keyboard enter. Wdyt? @quietbits

click-enter

@quietbits
Copy link
Contributor Author

This doesn't have to be included in this PR, but I'd like the 'save' button to be clickable by keyboard enter. Wdyt? @quietbits

click-enter

@jeesunikim , I like that suggestion. 👍 We can make Enter and Escape control the buttons. This would affect other "save" modals, so it's better to make it a separate ticket.

@jeesunikim
Copy link
Contributor

@quietbits I created a ticket #1401

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1392.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://laboratory-pr1392.previews.kube001.services.stellar-ops.com/

@quietbits quietbits merged commit 14381b4 into main May 9, 2025
5 checks passed
@quietbits quietbits deleted the saved-contracts branch May 9, 2025 12:40
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeesunikim jeesunikim jeesunikim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saved Contracts
3 participants
@quietbits @stellar-jenkins @jeesunikim