exp/services/webauth: add SEP-10 v1.2.0 implementation #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfeldstein
approved these changes
Dec 18, 2019
ire-and-curses
approved these changes
Dec 18, 2019
howardtw
reviewed
Dec 19, 2019
howardtw
reviewed
Dec 20, 2019
Comment on lines
+38
to
+41
| res := struct { | ||
| Transaction string `json:"transaction"` | ||
| NetworkPassphrase string `json:"network_passphrase"` | ||
| }{} |
There was a problem hiding this comment.
What's the reason that we are not doing var res challengeResponse here?
There was a problem hiding this comment.
I'm writing API tests, it's ideal if they don't use code they're testing, they should test all the code behind the endpoint and it's inexpensive to use a type here.
ire-and-curses
approved these changes
Dec 20, 2019
|
LGTM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
I've updated any docs (developer docs,.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
I've updated the relevant CHANGELOG (here for Horizon) ifneeded with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add SEP-10 web authentication implementation based on SEP-10 v1.2.0 that requires the master key have a high threshold for authentication to succeed.
Why
We need a standalone server implementation of SEP-10 for the mobile-wallet and this provides a server supporting the absolute basics of the existing SEP-10 protocol.
The SEP-10 protocol doesn't define what threshold a server should require a signing master key to have on an account, but for the sake of demonstration and our use case it requires the high threshold. It could be configurable but isn't at the moment.
This implementation has been written with the proposal in mind that we are making to SEP-10 (stellar/stellar-protocol#489) also, and already sets up the test cases with where we expect multi-sig to go but has those tests set with expectations that are appropriate given the limitations of SEP-10 today.
Known limitations
This application is not polished which is why it is being added to the
exppackage and why this is a draft PR.