Skip to content

all: remove travisci #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2019
Merged

all: remove travisci #1680

merged 1 commit into from
Aug 30, 2019

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Aug 30, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Remove .travis.yml and support for testing this repository on Travis CI.

Goal and scope

Simplify the CI files we need to manage and maintain. @bartekn pointed out in #1542 (comment) that we don't use TravisCI anymore and we shouldn't keep it around and expect it to be kept up to date. For contributors who fork the repository and have TravisCI installed as an application in their GitHub account TravisCI also runs in addition to CircleCI because this file is present, which is distracting given it's not the build system we're relying on.

Summary of changes

  • Remove .travis.yml.

Known limitations & issues

N/A

What shouldn't be reviewed

N/A

@leighmcculloch leighmcculloch requested a review from bartekn August 30, 2019 16:18
@leighmcculloch leighmcculloch merged commit 9573f42 into stellar:master Aug 30, 2019
@leighmcculloch leighmcculloch deleted the remove-travisci branch August 30, 2019 16:21
@leighmcculloch leighmcculloch self-assigned this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants