This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Remove use of dep and update version of Go to Go 1.13 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
force-pushed
the
modules
branch
from
5438d56 to
e31077e
Compare
leighmcculloch
requested review from
howardtw and
poliha
and removed request for
howardtw
leighmcculloch
changed the title
tomquisel
approved these changes
Sep 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove use of
depand update version of Go to Go 1.13.Goal and scope
The
stellar/gorepo was changed in stellar/go#1542 to use the build-in Go Modules instead of Dep for dependency management. The standardgocommands can now be relied on for downloading and installing dependencies without any need to run any additional commands like we had to with Dep. Go 1.13 is the latest version of Go and we should use it for these tests since the repository no longer supports Go 1.10.Close #6
Summary of changes
Known limitations & issues
N/A
What shouldn't be reviewed
N/A