Skip to content

Compatibility mode for Source Depot #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2017

Conversation

hoovercj
Copy link
Contributor

@hoovercj hoovercj commented Apr 8, 2017

Addresses #47

The main issues were:

  • Login isn't needed for Source Depot
  • Source Depot doesn't support ztags
  • Source Depot doesn't support the -T flag for fstat

@hoovercj
Copy link
Contributor Author

hoovercj commented Apr 8, 2017

  • I haven't been able to test sync because my team doesn't actually use sd sync directly.
  • Creating a new changelist from the commit box doesn't move the files from the default changelist. I don't think this is an important issue for sd, but please make sure I haven't broken that for perforce. I've tried it with and without the ztag flag and it made no difference, so I left the ztag flag in.

@stef-levesque stef-levesque merged commit 3e32dac into stef-levesque:master Apr 8, 2017
@stef-levesque
Copy link
Owner

Thanks! Nice work!

@hoovercj
Copy link
Contributor Author

hoovercj commented Apr 8, 2017

regarding the default changelist, it is my understanding that the "change" command should do it automatically.

The sync command shouldn't be removed. We have an "sd sync" and it is a valid command, it's just that my team doesn't use it directly so I can't test it. Please leave that in for others.

Hiding the login behind a setContext might work. I don't know why the config check wasn't working, maybe you can figure it out, otherwise we should open a vscode issue to get to the bottom of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants