Skip to content

Deactivating sticker pack sync #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

Samyoul
Copy link
Contributor

@Samyoul Samyoul commented Jun 20, 2022

What's Changed?

I've deactivated syncing of sticker packs because the current implementation introduces a regression on deletion of sticker packs.

Steps to reproduce

  • Pair device 1 and device 2
  • Add sticker pack 1 to device 1
  • device 2 received sticker pack 1
  • device 1 deletes sticker pack 1
  • device 2 adds sticker pack 2
  • device 2 receives late setting state of device 1 and does not remove sticker pack 1 because clock is older than when sticker pack 2 was added
  • device 1 receives update including sticker pack 1 and 2
  • device 1 has sticker pack 1 again and sticker pack 2

This issue can be fixed but requires more work to be done on #2717 Currently functionality in 2717 has merge only functionality and doesn't handle deletion either. Deletion is a bit trickier than merge only, can be fixed with a deletedAt field in the StickerPack struct, but will require coordination with desktop UI and mobile UI.

cc @churik and @audriu

Notes For QA:

This functionality removes syncing of sticker packs, so no sticker packs should be synced in testing

@ghost
Copy link

ghost commented Jun 20, 2022

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@Samyoul Samyoul self-assigned this Jun 20, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Jun 20, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 217e129 #1 2022-06-20 11:23:06 ~2 min linux 📦zip
✔️ 217e129 #1 2022-06-20 11:25:43 ~5 min android 📦aar
✔️ 217e129 #1 2022-06-20 11:26:10 ~5 min ios 📦zip

@Samyoul Samyoul merged commit dca550e into develop Jun 22, 2022
@Samyoul Samyoul deleted the fix/deactivate-sticker-syncing branch June 22, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested: mobile checked for regression on mobile client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants