Skip to content

Remove NetworkID from cluster #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 26, 2018
Merged

Conversation

adambabik
Copy link
Contributor

Our clusters do not depend on NetworkID anymore so we can remove it to avoid duplications of enodes.

In the near future, we will add LES support and LES servers do depend on NetworkID. In such a case, it's still gonna be better to define them like this:

type Cluster struct {
	StaticNodes     []string `json:"staticnodes"`
	BootNodes       []string `json:"bootnodes"`
	MailServers     []string `json:"mailservers"` // list of trusted mail servers
	RendezvousNodes []string `json:"rendezvousnodes"`
        LESServers []struct{
                NetworkID int
                Nodes []string
        } `json:"lesservers"`
}

@adambabik adambabik force-pushed the chore/remove-networkid-from-cluster branch from b10dd86 to c36e635 Compare August 23, 2018 10:40
@adambabik adambabik requested a review from divan August 23, 2018 15:20
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We eventually should start using https://fleets.status.im/ during build to fill in the data, but this is an improvement non-the-less.

@adambabik adambabik merged commit 3521c2a into develop Aug 26, 2018
@adambabik adambabik deleted the chore/remove-networkid-from-cluster branch August 26, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants