Skip to content

validate query range on requestMessages API #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

gravityblast
Copy link
Member

@gravityblast gravityblast commented Jun 25, 2018

This PR follows #1058, it adds the same validation but client-side, so that the client can receive an error and manage it or show a message to the user.

Copy link
Contributor

@pedropombeiro pedropombeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adriacidre adriacidre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we don't even need to hit the servers with invalid requests.

@gravityblast gravityblast merged commit 1bc63df into develop Jun 26, 2018
@gravityblast gravityblast deleted the fix/validate-request-messages-query-range branch June 26, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants