Skip to content

'Request to join required' setting is not saved after editing public community #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elina2015 opened this issue Jun 11, 2022 · 0 comments · Fixed by #6151
Closed

'Request to join required' setting is not saved after editing public community #6073

elina2015 opened this issue Jun 11, 2022 · 0 comments · Fixed by #6151
Assignees
@borismelnik
Labels
bug Something isn't working

Comments

@elina2015
Copy link

Bug Report

Steps to reproduce

  1. Create a community without request to join
  2. Go to edit it and change settings to 'Request to join required'
  3. Save it and edit the community again

Expected behavior

'Request to join required' setting is saved after editing the public community

Actual behavior

'Request to join required' setting is not saved after editing the public community

Additional Information

Screen.Recording.2022-06-10.at.9.35.19.PM.mov

Status desktop version: https://ci.status.im/job/status-desktop/job/branches/job/macos/job/master/2170/
Operating System: macOS Monterey, macOS Big Sur
@elina2015 elina2015 added bug Something isn't working Communities labels Jun 11, 2022
@iurimatias iurimatias moved this to Iteration Backlog in Status Desktop/Mobile Board Jun 19, 2022
@borismelnik borismelnik moved this from Iteration Backlog to In Progress in Status Desktop/Mobile Board Jun 20, 2022
borismelnik added a commit to status-im/status-go that referenced this issue Jun 20, 2022
@borismelnik
fix(community-edit): Save permissions when community edited
2d73a2b 
Part of: status-im/status-desktop#6073
@borismelnik borismelnik mentioned this issue Jun 20, 2022
Merged
borismelnik added a commit that referenced this issue Jun 20, 2022
@borismelnik
fix(communities): Fix broken Request to join required property
f5cb0d4 
Closes: #6073
@borismelnik borismelnik mentioned this issue Jun 20, 2022
Merged
@borismelnik borismelnik moved this from In Progress to In Code review & QA in Status Desktop/Mobile Board Jun 20, 2022
borismelnik added a commit that referenced this issue Jun 20, 2022
@borismelnik
fix(communities): Fix broken Request to join required property
8b151c3 
Closes: #6073
@elina2015 elina2015 added testing and removed testing labels Jun 21, 2022
@elina2015 elina2015 moved this from In Code review & QA to Done in Status Desktop/Mobile Board Jun 21, 2022
@iurimatias iurimatias moved this from Done to In Code review & QA in Status Desktop/Mobile Board Jun 21, 2022
iurimatias pushed a commit to status-im/status-go that referenced this issue Jun 21, 2022
@borismelnik
fix(community-edit): Save permissions when community edited (#2720)
8063152 
Part of: status-im/status-desktop#6073
iurimatias pushed a commit that referenced this issue Jun 21, 2022
@borismelnik @iurimatias
fix(communities): Fix broken Request to join required property
8d6311e 
Closes: #6073
iurimatias pushed a commit that referenced this issue Jun 21, 2022
@borismelnik @iurimatias
fix(communities): Fix broken Request to join required property
58eff9a 
Closes: #6073
Repository owner moved this from In Code review & QA to Done in Status Desktop/Mobile Board Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borismelnik borismelnik

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(communities): Fix broken Request to join required property status-im/status-desktop
3 participants
@iurimatias @elina2015 @borismelnik