-
Notifications
You must be signed in to change notification settings - Fork 280
revert MEV SSZ changes #7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert MEV SSZ changes #7044
Conversation
ignoring copyright year linter, want as clean a "revert" as possible |
why not simply assume deneb if the header is missing? we can also tell from the ssz data which fork it is, the header is just extra noise |
is the PR which did this, and it got rid of these https://github.com/status-im/nimbus-eth2/blob/v25.3.0/beacon_chain/spec/mev/rest_deneb_mev_calls.nim / https://github.com/status-im/nimbus-eth2/blob/v25.3.0/beacon_chain/spec/mev/rest_electra_mev_calls.nim / https://github.com/status-im/nimbus-eth2/blob/v25.3.0/beacon_chain/spec/mev/rest_fulu_mev_calls.nim with their In this case, part of the machinery for adding SSZ support removed this infrastructure. They could coexist, but that PR didn't approach it that way. |
The main reason not to merge this, really, is that we'll probably find out in 2 days that we'll need to do a mainnet release this month regardless. |
Well, there seems to be a sequencing problem here at the very least - ie the rest server must support the beacon api as it was specified at the beginning of deneb - v0.5.0 is newer than that, so until electra happens, the old implementation should have stayed as-is with whatever electra news being added on top of that. |
#7045 is a better approach |
This is requiring a
Eth-Consensus-Version
. This is required sincein https://github.com/ethereum/builder-specs/releases/tag/v0.5.0
But it's evidently not yet widely enough implemented to be relied upon, quite yet, so revert for now. It should be feasible when dropping the Deneb builder API to unconditionally assume this again.