feat(apollo_consensus): add CONSENSUS_CONFLICTING_VOTES_RATE alert #7042
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jun 8, 2025
guy-starkware
force-pushed
the
guyn/alerts/alert_conflicting_votes
branch
from
1f59a7b to
912d46b
Compare
guy-starkware
force-pushed
the
guyn/alerts/metric_conflicting_votes
branch
from
5ae8799 to
cc46bb1
Compare
asmaastarkware
requested changes
Jun 8, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/apollo_dashboard/src/alert_definitions.rs line 195 at r1 (raw file):
title: "Consensus conflicting votes rate", alert_group: AlertGroup::Consensus, expr: formatcp!("rate({}[1m])", CONSENSUS_VOTES_NUM_SENT_MESSAGES.get_name_with_filter()),
Personally, I prefer using the same time window across CONSENSUS_VOTES_NUM_SENT_MESSAGES_ALERT and the other related alerts for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.