Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow warmup iterations when not adapting #731

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

WardBrian
Copy link
Member

And, prevent adapting with no warmup

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #730

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

And, prevent adapting with no warmup
@WardBrian WardBrian requested a review from mitzimorris January 24, 2024 20:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46f8608) 79.82% compared to head (af8a747) 79.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #731      +/-   ##
===========================================
+ Coverage    79.82%   79.85%   +0.03%     
===========================================
  Files           75       75              
  Lines        11502    11502              
===========================================
+ Hits          9181     9185       +4     
+ Misses        2321     2317       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is ok

@WardBrian WardBrian merged commit e7e6121 into develop Jan 25, 2024
@WardBrian WardBrian deleted the fix/730-warmup-no-adapt branch January 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow iter_warmup when adapt_engaged = False
3 participants