Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Pathfinder arguments #727

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #726. Adds the new arguments from stan-dev/cmdstan#1234

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from mitzimorris January 19, 2024 21:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (078c43a) 79.81% compared to head (dc1b939) 79.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #727      +/-   ##
===========================================
+ Coverage    79.81%   79.83%   +0.01%     
===========================================
  Files           75       75              
  Lines        11463    11499      +36     
===========================================
+ Hits          9149     9180      +31     
- Misses        2314     2319       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! many thanks!

@WardBrian WardBrian merged commit e1bf7d9 into develop Jan 22, 2024
@WardBrian WardBrian deleted the feature/pathfinder-psis-config branch January 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New pathfinder arguments psis_resample and calculate_lp.
3 participants