Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download correct CmdStan tarball on non-x86 linux #616

Merged
merged 5 commits into from
Sep 15, 2022

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Sep 14, 2022

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #615. This PR changes the URL used in install_cmdstan to try to use the specific non-x86 linux binaries when applicable. It does its best to determine this automatically based on the value of platform.machine().

Users can specify an environment variable, CMDSTAN_ARCH, to override the default choice

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments but otherwise LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #616 (e9b00db) into develop (997a60b) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #616      +/-   ##
===========================================
- Coverage    80.42%   80.14%   -0.29%     
===========================================
  Files           69       69              
  Lines        10257    10338      +81     
===========================================
+ Hits          8249     8285      +36     
- Misses        2008     2053      +45     
Impacted Files Coverage Δ
...ork/cmdstanpy/cmdstanpy/cmdstanpy/utils/cmdstan.py 49.55% <0.00%> (-2.47%) ⬇️
a/cmdstanpy/cmdstanpy/cmdstanpy/utils/cmdstan.py 48.66% <0.00%> (-2.35%) ⬇️
a/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py 40.12% <0.00%> (+0.18%) ⬆️
cmdstanpy/cmdstanpy/install_cmdstan.py 39.81% <0.00%> (+0.18%) ⬆️
...k/cmdstanpy/cmdstanpy/cmdstanpy/install_cmdstan.py 39.81% <0.00%> (+0.18%) ⬆️
cmdstanpy/cmdstanpy/utils/cmdstan.py 53.57% <0.00%> (+1.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jbjuin
Copy link

jbjuin commented Sep 15, 2022

@WardBrian wouah ! That was fast :) Perfect for me ! Thanks a lot.

@ahartikainen ahartikainen merged commit 1c761ff into develop Sep 15, 2022
@jbjuin
Copy link

jbjuin commented Sep 15, 2022

@WardBrian any idea about the time for this to land in a release ?

@WardBrian
Copy link
Member Author

Are you able to confirm that this resolved the issue by installing from GitHub? After that it should be reasonably quick to release I think

@WardBrian WardBrian deleted the fix/615-cmdstan-arch-downloads branch September 15, 2022 15:46
@WardBrian WardBrian mentioned this pull request Sep 23, 2022
@jbjuin
Copy link

jbjuin commented Sep 28, 2022

Hi @WardBrian, sorry for the late reply.
We had other problems with ortools installation on this architecture and asked our partner to switch to amd64 machines.
I didn't check your modifications in that context. I may have a raspberrypi at hand to check this. I'm planning one hour within a month to try it. Thanks a lot for your fast solution and all the work on cmdstan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem when compiling on ARM
4 participants