-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download correct CmdStan tarball on non-x86 linux #616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments but otherwise LGTM
Codecov Report
@@ Coverage Diff @@
## develop #616 +/- ##
===========================================
- Coverage 80.42% 80.14% -0.29%
===========================================
Files 69 69
Lines 10257 10338 +81
===========================================
+ Hits 8249 8285 +36
- Misses 2008 2053 +45
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@WardBrian wouah ! That was fast :) Perfect for me ! Thanks a lot. |
@WardBrian any idea about the time for this to land in a release ? |
Are you able to confirm that this resolved the issue by installing from GitHub? After that it should be reasonably quick to release I think |
Hi @WardBrian, sorry for the late reply. |
Submission Checklist
Summary
Closes #615. This PR changes the URL used in
install_cmdstan
to try to use the specific non-x86 linux binaries when applicable. It does its best to determine this automatically based on the value ofplatform.machine()
.Users can specify an environment variable,
CMDSTAN_ARCH
, to override the default choiceCopyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: