Skip to content

drop duplicate .version file #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2020
Merged

drop duplicate .version file #89

merged 2 commits into from
Nov 3, 2020

Conversation

davidkarlsen
Copy link
Collaborator

@davidkarlsen davidkarlsen commented Oct 28, 2020 •
edited
Loading

You have two .version files with different casing - this makes it hard to use git on some filesystems - and one contains wrong version.

This change is Reviewable

@stakater-user
Copy link
Contributor

@davidkarlsen Image is available for testing. docker pull stakater/gitwebhookproxy:SNAPSHOT-PR-89-2

@stakater-user
Copy link
Contributor

@davidkarlsen Image is available for testing. docker pull stakater/gitwebhookproxy:SNAPSHOT-PR-89-1

@davidkarlsen
Copy link
Collaborator Author

@hazim1093 PTAL - so that we can get in other fixes after this.

@hamza3202
Copy link
Contributor

Thanks @davidkarlsen

@hamza3202 hamza3202 merged commit 23de9e3 into stakater:master Nov 3, 2020
@davidkarlsen davidkarlsen deleted the cleanversion branch November 4, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza3202 hamza3202 hamza3202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidkarlsen @stakater-user @hamza3202