Skip to content

ROX-28461: Add change cloud_account and subscription_Id admin endpoint #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented May 19, 2025

Description

We need a new endpoint to update subscription_id and AWS account link. it is for the edge case when AMS subscription is deleted and tenant is restored. In this case we cannot use an existing PatchBillingParameters because it will return an error

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur
Copy link
Contributor

kovayur commented May 19, 2025

There's already a PatchBillingParameters endpoint

@kurlov
Copy link
Member Author

kurlov commented Jun 6, 2025

There's already a PatchBillingParameters endpoint

unfortunately, PatchBillingParameters will not work when there is deleted subscription and AMS will simply return an error. I had to manually create a new subscription for the account with deleted one and we need new endpoint which will only update subscription_id and AWS account

@kurlov kurlov changed the title ROX-28461: Add change cloud account admin endpoint ROX-28461: Add change cloud_account and subscription_Id admin endpoint Jun 6, 2025
Copy link
Contributor

openshift-ci bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

New changes are detected. LGTM label has been removed.

@kurlov kurlov merged commit 6b05a74 into main Jun 10, 2025
16 of 17 checks passed
@kurlov kurlov deleted the akurlov/ROX-28461-add-changing-subscription-and-cloud-account-endpoint branch June 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants