ROX-28506: Rename dinosaur to central Part 1 #2291
Conversation
kurlov
changed the title
kurlov
force-pushed
the
akurlov/ROX-28506--dinosaur-to-central
branch
from
58a3998 to
3db6bd6
Compare
kurlov
changed the title
…into akurlov/ROX-28506-rename-dinosaur-to-central-1
CONTRIBUTING.md
Outdated
| @@ -23,8 +18,8 @@ Project source is to be found under `$GOPATH/src` by a distinct directory path. | |||
| /cmd | |||
| /fleet-manager -- Main CLI entrypoint | |||
| /internal -- service specific implementations | |||
| /dinosaur -- should be renamed to central | |||
| providers.go -- dinosaurs service injection setup | |||
| /central -- should be renamed to central | |||
There was a problem hiding this comment.
I think you can remove the -- should be renamed to central here.
There was a problem hiding this comment.
Oops, replaces with a short description what is Central instead
README.md
Outdated
| @@ -122,11 +122,9 @@ $ make db/migrate | |||
|
|
|||
| #### Background | |||
|
|
|||
| This project was started from a fleet-manager template with an example "Dinosaur" application as a managed service. | |||
| Implementations which reference "Dinosaur" are replaced iteratively. | |||
| This project was started from a fleet-manager template. | |||
There was a problem hiding this comment.
I'd leave the context about Dinosaurs here, since we still have a few dinosaurs after this PR.
| - Any endpoints that should only be used by an agent or by other internal components should be added here. | ||
|
|
||
| Further customizations for existing endpoints are described in the following sections below. | ||
|
|
||
| ### (GET) /api/dinosaurs_mgmt/v1/agent-clusters/{id} | ||
| ### (GET) /api/centrals_mgmt/v1/agent-clusters/{id} |
There was a problem hiding this comment.
I think you need to review the PR for the API paths. I noticed multiple times that dinosaurs_mgmt was replaced by centrals_mgmt but our API paths were actually renamed from /api/dinosaurs_mgmt to /api/rhacs
| genericvalidation "k8s.io/apimachinery/pkg/api/validation" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
Not sure why this isn't counted as moved, but I trust CI to verify validation is still correct.
There was a problem hiding this comment.
That's odd, locally it showed that I renamed. Github is smart and can detect renaming even if you git mv wasn't used explicitly, but looks like it can also consider renaming as a new file for some reason 😕
There was a problem hiding this comment.
I explicitly used git mv command to rename certain files to keep git history but still they marked as a new ones. Another example pkg/db/central.go or internal/central/pkg/workers/ folder
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adopt
dinosaurfrom the the original template tocentral. Removed a few unused filesout of scope of this PR:
This will be in the following PR