[feat] Event Patching, Improve authentication, and status handling #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unused authentication parameters for cleaner logic Updates PostCSS configuration to use the correct Tailwind plugin name Improves code readability and maintainability
Adds utility functions to determine open event statuses Refactors event filtering logic to enhance readability and maintainability
Adds support for start and end date inputs using dayjs for better date formatting. Disables date fields based on event type and status, ensuring a more intuitive user experience. Includes loading state for the submit button to prevent multiple submissions. Relates to user feedback on event management.
Implements improved date validation for event start and end times. Replaces status update mechanism with a more robust API call. Enhances user experience by integrating loading state during submission.
Adds a check to skip empty RegionServices for better logging Refines status assignment logic for 'Changed' and 'ImpactChanged' statuses Updates history ID assignment to use the update ID instead of a counter
Eliminates SD_REDIRECT_URL, SD_LOGOUT_REDIRECT_URL, and SD_AUTH_SECRET from workflow files and Dockerfile to streamline the build process. Improves security by reducing the exposure of unnecessary secrets.
Aloento
requested review from
sgmv,
bakhterets,
anton-sidelnikov and
SebastianGode
sgmv
reviewed
Feb 3, 2025
| @@ -54,6 +54,3 @@ jobs: | |||
| SD_BACKEND_URL=${{ secrets.SD_BACKEND_URL }} | |||
| SD_CLIENT_ID=${{ secrets.SD_CLIENT_ID }} | |||
There was a problem hiding this comment.
Is it still relevant? Could you please double check env variables with examples.
There was a problem hiding this comment.
it is relevant, any problem?
SD_BACKEND_URL="https://localhost:8080"
SD_CLIENT_ID=""
SD_AUTHORITY_URL=""The front end still needs the basic information from the Auth to process the token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request:
This PR introduces multiple improvements across authentication, event management, and status handling:
Authentication & Configuration Enhancements:
Event Management Enhancements:
Status Handling Improvements:
Other Improvements: