[Refactor] Availability Page to Fetch Data from Backend #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unused SLA helper
…te dependencies in package.json
… update package dependencies
| @@ -77,7 +77,7 @@ export function useAvailability(category: Models.ICategory, topic: string) { | |||
| const rs = DB.RegionService.find(x => x.Id === service.id); | |||
|
|
|||
| if (!rs) { | |||
| log.warn("Service not found.", service); | |||
| log.info("Service not found.", service); | |||
There was a problem hiding this comment.
because it's a hidden service by design if not found.
anton-sidelnikov
requested changes
Dec 12, 2024
| interface ServiceAvaEntity { | ||
| id: number | ||
| name: string | ||
| availability: AvaliaEntity[] |
| region: string | ||
| } | ||
|
|
||
| interface AvaliaEntity { |
| Percentages: Array(6).fill(100) | ||
| }))); | ||
|
|
||
| const url = process.env.SD_BACKEND_URL; |
There was a problem hiding this comment.
maybe better to extract this type of const from method?
There was a problem hiding this comment.
After compiling, it will be statically replaced with a const string and inline.
const url = "https://...";
so, it's fine here, XD
anton-sidelnikov
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR focuses on improving the functionality, performance, and maintainability of the application by transitioning the Availability page's data management from real-time computation to fetching data from the backend. The changes include:
Key Changes
Refactor
IStatusContextandEmptyDBHistoriesto simplify and clean up the data model.Enhanced Subject Retrieval
New Custom Hook:
useAvailabilityuseAvailability, to manage service availability data effectively.Updated
CategoryGroupComponentuseAvailabilityhook for consistency and better data flow.