[refactor] Read Env in running time #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no, it is required app to read environment vars from |
sgmv
requested changes
Nov 26, 2024
…for application startup
SebastianGode
requested changes
Nov 26, 2024
|
keep original dockerfile |
…p and implement Express server
SebastianGode
previously approved these changes
Nov 26, 2024
… Dockerfile for Nginx setup
…ginx in the foreground
sgmv
requested changes
Nov 26, 2024
SebastianGode
previously approved these changes
Nov 26, 2024
vladimirvshivkov
previously approved these changes
Nov 26, 2024
sgmv
previously approved these changes
Nov 27, 2024
vladimirvshivkov
approved these changes
Nov 27, 2024
vladimirvshivkov
temporarily deployed
to
github
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR focuses on improving the functionality, performance, and maintainability of the application with the following changes:
Changes
Update entrypoint script to change directory and simplify start command
Update Dockerfile and add entrypoint script; remove nginx configuration