[refactor] Update OIDCProvider & EventItem #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point construction in Status service
…and redirect paths
…guration and simplify sign-in/sign-out callbacks
…d from the application
Aloento
changed the title
Aloento
changed the title
sgmv
reviewed
Nov 26, 2024
.env.exmaple
Outdated
| @@ -0,0 +1,7 @@ | |||
| SD_BACKEND_URL="/v2" | |||
There was a problem hiding this comment.
As an example, it should be more detailed. I'm suggesting to put here something like
SD_BACKEND_URL="http://localhost:8080/v2"
.env.exmaple
Outdated
| SD_BACKEND_URL="/v2" | ||
|
|
||
| SD_CLIENT_ID="" | ||
| SD_AUTHORITY="" |
There was a problem hiding this comment.
Is this env variable for an authority url? If yes, please add _URL to the end.
…ew variable names and local backend URL
sgmv
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR focuses on improving the functionality, performance, and maintainability of the application with the following changes:
Changes
EventItemcomponent to improve readability and maintainability.