[enhancement] Improve event handling for Reopened and maintenance statuses #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the Reopened status in the EventStatus enum. Updates the GetStatusString function to correctly return the string representation for the Reopened status. Enhances the TransformerV2 function to handle Reopened status during transformations.
Updates the EventCard component to conditionally render the current status label and status value based on the event type. This improves clarity by preventing unnecessary information from being displayed for maintenance-related events.
Refines the handling of start and end dates for maintenance events. Removes redundant date assignments and ensures proper status updates for non-maintenance events. Improves overall clarity and maintainability of the event editing logic.
Eliminates jsdom from the project dependencies to streamline the package requirements. Updates various packages to the latest versions for improved performance and security, including eslint-utils and caniuse-lite. Removes unnecessary types from the tsconfig for cleaner configuration.
Aloento
requested review from
sgmv,
bakhterets,
anton-sidelnikov and
SebastianGode
This was
linked to
issues
Apr 16, 2025
sgmv
requested changes
Apr 17, 2025
sgmv
requested changes
Apr 23, 2025
sgmv
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request:
This PR includes several key updates and fixes related to event status management and UI rendering logic:
[Enhancement] Reopened Status Support:
Reopenedstatus within theEventStatusenum.GetStatusStringutility to return the appropriate string representation for the newReopenedstatus.TransformerV2to handle the transformation logic associated withReopenedevents.[WorkAround] Status Display for Maintenance Events requested by @sgmv
[Refactor] Maintenance Event Date Handling:
startandenddates of maintenance-type events.