[feat] Enhance session notification #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates unnecessary skeleton loading indicators to streamline the code. Improves performance by removing `useRef` and `useInViewport` hooks. Reduces complexity and enhances maintainability of the History component.
Cleans up the codebase by removing obsolete user authentication methods and imports related to OIDC. This simplifies the code structure and reduces potential confusion for future development.
Adds toast notifications for login expiration alerts Refactors authentication error handling to use `useEffect` Integrates Fluent UI components for improved UI consistency Relates to user experience improvements
Adjusts the position of the logout menu item to enhance user experience by placing it at the end of the profile menu. No functionality changes were made.
Aloento
requested review from
sgmv,
bakhterets,
anton-sidelnikov and
SebastianGode
|
Please check the description for #102 . But we can improve it. With 3 different points:
|
|
I designed the new error message to pop up in the bottom right corner. Can't use centre of the window popups, they conflict with existing modal popups (modify event). stakeholder already approved the design and behavior. |
Replaces direct signoutRedirect calls with signoutSilent for a smoother user experience. Ensures that the logout process does not disrupt the user flow. Improves handling of user sessions in the authentication process.
Replaces direct usage of user access token with a utility function for token retrieval. Enhances separation of concerns and improves code maintainability in the event handling components.
sgmv
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request:
This PR includes a series of enhancements and refactors aimed at improving user experience, code maintainability, and performance across the History and Authentication components.
Key Changes:
History Component Cleanup:
useRefanduseInViewporthooks to improve performance and reduce complexity.Authentication Code Refactor:
useEffectfor better reactivity and error awareness.User Session Management Enhancements:
UX Adjustment:
fixes #112, #102