-
Notifications
You must be signed in to change notification settings - Fork 78
feat(messages): polish pagination and filtering #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
alex-mcgovern
wants to merge
19
commits into
main
from
feat/messages/polish-pagination-and-filtering
Closed
feat(messages): polish pagination and filtering #1213
alex-mcgovern
wants to merge
19
commits into
main
from
feat/messages/polish-pagination-and-filtering
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the API to add pagination to those endpoints, to be able to render faster in the browser Closes: #1020
* feat: filter messages by ID * lint fix * fix: use `.bindparams` for `filter_by_ids`
…eupduplicate-response
yrobla
approved these changes
Mar 5, 2025
This was referenced Mar 5, 2025
I've been doing some manual testing — it's a bit of a mess. Some of the issues I've found are:
I think a lot of the issues originate from the behaviour in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on @yrobla's work in #1186 for pagination for
/v1/workspaces/:name/messages
trigger_type
We're not configured yet to run integration tests on workspace crud (but will be after #1170) so I've just manually verified the changes.
TODO:
total count is broken, so in the UI there are buttons to nonexistent pagesUsage
Without filtering:
By `prompt_id
Filtering by a single ID:
Filtering by multiple IDs:
Filtering by non-existent ID:
Filtering by non-existent ID:
By
trigger_type
(Note: I only have secrets detected in this DB)