Skip to content

unittest/python : add visualizer bindings visitor test, add CMake util to create C++ Python modules for tests #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ManifoldFR
Copy link
Member

  • unittest/python/CMakeLists.txt : add util function to create test C++ extension Python modules, and associated Python tests
  • unittest/python : add test for visualizer bindings (visitor)

@ManifoldFR ManifoldFR requested a review from jorisv April 16, 2025 12:01
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@ManifoldFR ManifoldFR changed the title unittest/python : add visualizer bindings visitor test unittest/python : add visualizer bindings visitor test, add CMake util to create C++ Python modules for tests Apr 16, 2025
@ManifoldFR ManifoldFR force-pushed the topic/visualizers/add-unit-test branch from 32404eb to e35bcc8 Compare April 16, 2025 12:19
jcarpent
jcarpent previously approved these changes Apr 16, 2025
… extension Python modules, and associated Python tests

+ this commit was amended:
  - fixed EXCLUDE_FROM_ALL being on the wrong if/else branch
@ManifoldFR ManifoldFR force-pushed the topic/visualizers/add-unit-test branch from 04bf63c to 426464e Compare April 16, 2025 13:29
@ManifoldFR
Copy link
Member Author

ManifoldFR commented Apr 16, 2025

@jorisv suggested 86547fb could fix the windows problem.

edit nope, didn't fix it :(

@ManifoldFR ManifoldFR force-pushed the topic/visualizers/add-unit-test branch from 86547fb to 51507ac Compare April 16, 2025 14:31
@ManifoldFR
Copy link
Member Author

Following discussion with @jorisv, we've decided to temporarily not run the test on Windows until we have normalized paths for the binaries (like what he did for eigenpy).

@ManifoldFR
Copy link
Member Author

@jcarpent this should be ready to merge.

@jcarpent jcarpent merged commit d1e1f68 into stack-of-tasks:devel Apr 16, 2025
26 checks passed
@ManifoldFR ManifoldFR deleted the topic/visualizers/add-unit-test branch April 16, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants