Pv/retain bbox intersects parameters #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
force-pushed
the
pv/retain-bbox-intersects-parameters
branch
from
5e627ca to
a8071fc
Compare
philvarner
commented
Mar 7, 2022
| res.sendStatus(409) | ||
| } else { | ||
| next(error) | ||
| const itemRes = await api.getItem(collectionId, itemId, es, req.endpoint) |
There was a problem hiding this comment.
validate the item exists for a put rather than just the collection (should have been pulled into another PR, but here we are)
philvarner
commented
Mar 7, 2022
| @@ -67,17 +67,6 @@ test('POST /collections/:collectionId/items', async (t) => { | |||
| t.assert(response.headers['location'].endsWith(`/collections/${collectionId}/items/${itemId}`)) | |||
| t.is(response.body, 'Created') | |||
|
|
|||
| // now test mismatched collection ids, while we wait a second for our item propagate | |||
There was a problem hiding this comment.
this had been pulled into another test, but not deleted here.
philvarner
commented
Mar 7, 2022
| @@ -77,12 +77,12 @@ test('PUT /collections/:collectionId/items/:itemId', async (t) => { | |||
| test('PUT /collections/:collectionId/items/:itemId for a non-existent collection or id returns 404"', async (t) => { | |||
| const { collectionId } = t.context | |||
|
|
|||
| t.is((await t.context.api.client.patch( | |||
| t.is((await t.context.api.client.put( | |||
There was a problem hiding this comment.
missed updating these tests when copied the patch tests to put tests.
matthewhanson
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Proposed Changes:
PR Checklist: